From fb8f0ea7b31d78e8a14d79549a76fd71de390907 Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 1 Apr 2024 23:54:53 -0300 Subject: [PATCH] avformat/mov: don't read key_size bytes twice in the keys atom We only support mdta as type, yet we were not skipping other types, but rather reading key_size worth of bytes twice per entry. Signed-off-by: James Almer (cherry picked from commit 5a06d3810e41134ee9c2941cc0b371da62b539db) --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index d551a0f8e0..056890c85b 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5048,6 +5048,7 @@ static int mov_read_keys(MOVContext *c, AVIOContext *pb, MOVAtom atom) key_size -= 8; if (type != MKTAG('m','d','t','a')) { avio_skip(pb, key_size); + continue; } c->meta_keys[i] = av_mallocz(key_size + 1); if (!c->meta_keys[i])